twofas / 2fas-browser-extension

Source code for 2FAS Browser Extension
https://2fas.com/browser-extension
GNU General Public License v3.0
266 stars 36 forks source link

bug: Slowdown / non-standard browser load #67

Closed Stepan-H closed 5 months ago

Stepan-H commented 8 months ago

Browser info

Mozilla Firefox 123.0 64bit

Browser extension version

1.6.3

Website

No response

Bug description

Extreme and long CPU using during/after page loading. Firefox offers to disable the add-on because of this. So far, this is only happening to me on the company's intraweb pages.

In Firefox I got this from the about:processes, see image attachment. Red line shows "15,8s Jank - event procesing delay" 2FAS issue 202303011511

Solution

No response

Additional context

No response

Acknowledgements

FWest98 commented 8 months ago

I was about to report the same, I noticed since last night that Firefox slows down massively on GitLab diffs. I have not encountered this before, and indeed also for me it suggests stopping the 2FAS plugin.

GrzegorzZajac000 commented 8 months ago

I apologize for the inconvenience caused by this issue returning. I will investigate that ASAP.

GrzegorzZajac000 commented 7 months ago

I will be fixed with v1.6.4

brandoningli commented 7 months ago

Just want to document that I'm experiencing this same issue on the AWS console. Will keep an eye out for the v1.6.4 rollout!

last-partizan commented 7 months ago

This means, 2fa extension runs on every page without user interaction?

Maybe better way to solve this - is to run extension only after user clicks extension icon?

GrzegorzZajac000 commented 7 months ago

@last-partizan Interesting idea. At the moment this is not entirely possible, but after the changes we are planning, I will try to implement it.

SAJewers commented 7 months ago

Getting this searching Steam as well.

zirdum commented 7 months ago

I've noticed the same issue with slowdown switching between sections within the "You Need a Budget" site, but using the Chrome browser (v122.0.6261.112) on a macbook. When I disable the extension it runs normally.

jandroav commented 7 months ago

Also happening in Brave

Tornadoalley commented 7 months ago

I had to uninstall 2FAS until this can be resolved. I am using Firefox on Windows 11 and 10.

iGlitch commented 7 months ago

Similar experience as aforementioned (on TheLounge IRC)

Any way to make an exclude domain list? Similar to what exists for the auto-submit exclude list... but it would be just complete exclude from running at all domain list.

KobeW50 commented 7 months ago

Similar experience as aforementioned (on TheLounge IRC)

Any way to make an exclude domain list? Similar to what exists for the auto-submit exclude list... but it would be just complete exclude from running at all domain list.

The browser extension itself doesn't support this, but some browsers may have such a feature to manage which browser extensions can run on which pages.

Enivex commented 7 months ago

Also happening on https://typst.app/docs/reference/symbols/sym/

(Or possibly some other issue)

Using the search box on the right slows Firefox down to a crawl.

GrzegorzZajac000 commented 7 months ago

v1.6.4 was uploaded to stores. Should be available in next hours.

Enivex commented 7 months ago

v1.6.4 was uploaded to stores. Should be available in next hours.

Is it expected to fix these issues?

FWest98 commented 7 months ago

While the performance in 1.6.4 is better, it is still very choppy compared to running without the plugin (and compared to previous versions).

Maybe of interest is that the issue for me mainly pops up when I leave a tab in the background for a while and return to it. On some pages, such as large GitLab diffs, the effect is immediate, but in most cases the issue only manifests itself as a "hanging" or stuttery tab when returning to it. Only a refresh then solves the issues temporarily.

GrzegorzZajac000 commented 7 months ago

@FWest98 We know the problem wasn't solved perfectly, but we wanted to solve the problem as quickly as possible. I'm already working on version 1.7.0, which will slightly change the way it works in the direction that @last-partizan described.

Stepan-H commented 7 months ago

Thank you. It's better than before, but as you wrote, It's not best solution. Browser does not stuck and does not show turn-off addon offer, but there are stil remain CPU loading problem. I look forward to a revised version 1.7. and wish you all the best with your rework.

Enivex commented 7 months ago

I can confirm that https://typst.app/docs/reference/symbols/sym/ works much better now

gcstang commented 7 months ago

Same issue on 1.6.4 for FF 124.0.1 (64-bit) on macOS 13.6.4 (22G513) Firefox notified me 2FAS extension is slowing down all page loads and had to disable it (3/25/2024) I move from Chrome thinking it was the browser but it seems like it's the same exact issue in FF, disabling fixes the browser load times.

Andrew15-5 commented 7 months ago

YouTube Music is also affected. Previously only with this extension enabled it would spontaneously start loading CPU after some time until I reload the page. Today, the Firefox even gave me the notification and the player didn't play the next song until I pressed "Stop" button.

image

mryx007 commented 6 months ago

Why didn't you do a rollback? It took me so much time to figure out what the problem was. I even reinstalled the browser. Fortunately, I finally figured out what the issue was. The problem persists even with Edge 123. I will never install this extension again.

GrzegorzZajac000 commented 6 months ago

@mryx007 Previous versions contained other bugs, and slowdown has always occurred in some form. Version v1.7.0, which introduces a new mechanism and eliminates this problem, is already in our internal tests. It will be publicly available soon.

GrzegorzZajac000 commented 6 months ago

v1.7.0 was uploaded to stores. Should be available in next hours. Thanks one more time for @last-partizan for comment. We implemented this idea by adding a few more changes ;)