twofas / 2fas-browser-extension

Source code for 2FAS Browser Extension
https://2fas.com/browser-extension
GNU General Public License v3.0
266 stars 36 forks source link

bug: Extension severely slows down the browser when a lot of elements get added to the DOM #71

Closed griffi-gh closed 7 months ago

griffi-gh commented 7 months ago

Browser info

Firefox 123.0.1 (Windows)

Browser extension version

1.6.3

Website

Any website which adds a lot of elements to the DOM, such as github repos with tons of files.

Bug description

image

Stopping the extension (using the "Stop" button) causes all slowdown issues to go away (until the page is reloaded), actions that used to take a couple of seconds/freeze the tab now finish instantly

Comparison of page performance:
With extension enabled:

https://github.com/twofas/2fas-browser-extension/assets/45996170/1b176510-253b-497c-9f5b-abfaf28cb52b

With extension disabled:

https://github.com/twofas/2fas-browser-extension/assets/45996170/45a5d6ab-1f57-4b45-9bd1-a47f99b1d4c8

The difference is night and day.

Solution

No response

Additional context

No response

Acknowledgements

griffi-gh commented 7 months ago

oops didn't realize that it's a duplicate of #67