search

twofas / 2fas-ios

Source code for 2FAS iOS app
GNU General Public License v3.0
505 stars 38 forks source link

Raivo OTP import silently skips entries having secret seeds with spaces #42

Closed ghost closed 11 months ago

ghost commented 11 months ago

Steps to reproduce:

  1. Create a token in Raivo OTP making sure to add spaces in the secret seed
  2. Export to ZIP, then unzip it
  3. Import the .json into 2FAS
  4. The token in question is silently skipped

This is made particularly serious by the present context: Raivo's main dev quietly sold out the whole community who gathered around his app to some dubious company with unclear privacy practices and then walked away whistling, so we can expect a lot of Raivo OTP users coming over to 2FAS, and they'll lose some of their tokens because of this bug.

adocyn commented 11 months ago

@foobar-1676 Hi, upcoming 5.0 should handle that scenario better 👍

ghost commented 11 months ago

Better?

Data is being lost silently, this needs a hotfix obviously if one has any sense whatsoever.

adocyn commented 11 months ago

@foobar-1676 Please check if 5.0 did fix this issue for you.