search

twofas / 2fas-ios

Source code for 2FAS iOS app
GNU General Public License v3.0
505 stars 38 forks source link

Feature: hide in background #60

Closed madahian closed 9 months ago

madahian commented 9 months ago

Changes Implemented:

Implemented a feature to enhance security and privacy by hiding 2FA tokens and the app contents when it transitions to the background. Displayed a splash screen to replace hidden content when the app is in the background or visible in the app switcher.

Details:

Added functionality to hide sensitive content within the app during applicationWillResignActive() event to secure user data from being visible when the app is not active. Displayed a splash screen, dynamically adapting to the app's theme, to provide a secure placeholder in the background state. Utilized appropriate UI transitions to smoothly switch between the splash screen and the app's content based on the app's lifecycle.

Testing:

Tested the implemented feature thoroughly to ensure that the content hiding and splash screen display functions accurately during background transitions and app switching. Conducted checks using SwiftLint to ensure adherence to coding standards, eliminating any linting warnings. Verified the functionality across different scenarios to confirm expected behavior without introducing regressions.

adocyn commented 9 months ago

Hi @madahian Thanks for PR, but you've managed to get the worst timing. We've actually added that to 5.2.0 which is in tests right now. We're also handling cases where keyboard is visible, and we've redone the "top" of the app, modularised it and finally bring up to date with the architecture of the rest of the app. So unfortunately I'll have to close it without merging.