search

twogood / dynamite

PKWARE Data Compression decompressor tool and library
Other
12 stars 2 forks source link

please attribute copyright to Hans de Goede #1

Open a-detiste opened 8 years ago

a-detiste commented 8 years ago

@evgeni @jwrdegoede

Can you please attribute due copyright + MIT license grant to Hans de Goede for id-shr-extract.c ?

Greets,

Alexandre Detiste

---------- Message transmis ---------- Objet : Re: port of game-data-packager to Fedora Date : mardi 3 novembre 2015, 09:54:35 De : Hans de Goede j.w.r.degoede@gmail.com À : RPM Fusion developers discussion list rpmfusion-developers@lists.rpmfusion.org

Hi,

For example I already spotted that fedora "dynamite" package is lacking id-shr-extract program needed to unpack wolf3d shareware; but rpmfusion provides "wolf3d-shareware.noarch" sot this is not a problem.

Heh, I did not know that that little utility I wrote for the wolf3d-shareware / clonekeen packages ended up in the dynamite svn / debian dynamite package. If you look at id-shr-extract.c it is a copy of the extract.c from the rpmfusion sources, and it is:

  Copyright (C) 2007 Hans de Goede  <j.w.r.degoede@hhs.nl>

I do notice that they've stripped the rest of the copyright header though, which said:

 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 2 of the License, or
 (at your option) any later version.

 ...

In the svn patch in the Debian pkg the header is just:

/* utility to extract the .SHR installer data files of early ID software shareware games

 Copyright (C) 2007 Hans de Goede  <j.w.r.degoede@hhs.nl>

*/

:|

I guess upstream dynamite may have done this because the rest of dynamite is MIT licensed, I wish they would have just asked though (maybe they could not find me as me @hhs.nl email has been dead for ages)

For the record I'm fine with re-licensing this tiny blurb of source-code under MIT.

twogood commented 8 years ago

Thanks! Of course I will make sure we have a proper attribution.

In the meantime, please review http://sourceforge.net/p/synce/patches/31/ for the history around inclusion of id-shr-extract.c

jwrdegoede commented 8 years ago

Hi,

Ah, so I did give permission already, I did not remember, sorry.

Note that the Summary of this issue is slightly off. My copyright was maintained in the current code, it is just that the GPL license header was removed without replacing it with a BSD (or MIT) one. As said in the sf ticket, I'm fine with the re-licensing.

On closer inspection I see that none of the other .c files have a license header either, the only license-statement is in the LICENSE file, which does point the id-shr-extract.c, so there really is no issue (my bad, sorry) and this ticket can be closed.

Preferably all .c files would be given a proper copyright + license headers, this is generally seen as better then just having a single top level LICENSE file.

Regards,

Hans

a-detiste commented 8 years ago

Sorry for the confusion,

The "Can you please attribute due copyright to Hans de Goede for id-shr-extract.c" was originaly only meant for debian/copyright, so there's nothing to fix here; this can be handled in a 0.1.1-3 package.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803925

twogood commented 8 years ago

I admit to a certain laziness regarding proper copyright + license headers!

And I might have switched from BSD to MIT license without consulting Hans, sorry about that.