twogood / unshield

Tool and library to extract CAB files from InstallShield installers
MIT License
340 stars 73 forks source link

Fixed default build of shared library #109

Closed r-a-sattarov closed 3 years ago

r-a-sattarov commented 3 years ago

fix https://github.com/twogood/unshield/issues/108

twogood commented 3 years ago

Some Linux builds fail like this, any suggestion?

[ 73%] Linking C shared library liblibunshield.so

/usr/bin/ld: convert_utf/libconvert_utf.a(ConvertUTF.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC

clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

make[2]: *** [lib/CMakeFiles/libunshield.dir/build.make:195: lib/liblibunshield.so] Error 1

make[1]: *** [CMakeFiles/Makefile2:140: lib/CMakeFiles/libunshield.dir/all] Error 2

make: *** [Makefile:133: all] Error 2
twogood commented 3 years ago

Great job, thank you @r-a-sattarov!