search

twogood / unshield

Tool and library to extract CAB files from InstallShield installers
MIT License
340 stars 73 forks source link

CI: Expand on the test matrix #163

Closed bwrsandman closed 9 months ago

bwrsandman commented 2 years ago

This PR converts the test matrix from using only include cases to using a matrix of parameters and excluding the combinations we want to skip. The build type is moved from env to be a matrix parameter. It then expands on the permutations to make testing more complete.

twogood commented 2 years ago

IIRC CVE-2015-1386 will fail on multiple platforms because it requires GNU extensions to realpath

kratz00 commented 2 years ago

I like the idea. I also have a few draft PRs which are touching this topic. Maybe we should define what should be achieved first.

The test matrix might get really big, as there are many variables:

And we also should define which binaries to keep and offer for download on the release page for instance. Does this make sense?

twogood commented 2 years ago

I really don't want a big matrix. A single big endian build+test is enough for example. Release builds only should be enough, etc.

twogood commented 2 years ago

Windows downloads would be most useful!

bwrsandman commented 2 years ago

You can reduce the size of the matrix by building multiple configurations in the same job as separate steps. OS are one dimension that is required to be in the matrix, everything else not as much, but then the permutations must be input by hand.

bwrsandman commented 2 years ago

Are you interested in cross compiling to iOS, ARM, Android, webasm?

bwrsandman commented 2 years ago

Removed the Debug permutation as requested. I left in the Static/Non-static in the last commit but it can be removed also.