Fix multiple issues with MSVC Windows build

twogood / unshield

Tool and library to extract CAB files from InstallShield installers

MIT License

332 stars 71 forks source link

Closed elasota closed 6 months ago

elasota commented 6 months ago

This fixes several problems with MSVC build and Windows:

Adds VS things to .gitignore
Fixes path processing not handling backslash separators
Fixes extract failure with absolute paths due to the directory existence check attempting to call stat on the drive, which doesn't work, then attempting to call _mkdir for the drive, which also doesn't work
Fixes libunshield not exporting any symbols in DLL configuration

twogood commented 6 months ago

Thank you @elasota and Happy New Year!

twogood commented 6 months ago

Thanks @bwrsandman , looks like we might need a new PR to improve this one :)