twolfson / commander-completion

Shell completion for commander.js
The Unlicense
26 stars 4 forks source link

Make `git remote |` example work #5

Closed drifkin closed 9 years ago

drifkin commented 9 years ago

I think there needs to be a space added to the "git remote" line in the git example.

This is the behavior I'm seeing:

Current (without a space):

program.complete({
  line: 'git remote',
  cursor: 11
}, function (err, results) {
  results; // ['remote']
});

New (with a space):

program.complete({
  line: 'git remote ',
  cursor: 11
}, function (err, results) {
  results; // ['add', 'remove']
});
twolfson commented 9 years ago

Ah, damn. This was before I started running the scripts I put in my documentation.

Nice catch, looks good =) I will land this by the end of the weekend.

twolfson commented 9 years ago

This has been landed in 0.4.1. Thanks for your help =)

drifkin commented 9 years ago

Thanks for getting it fixed up quickly!

And more importantly thanks for this package! I just started looking into getting completion working for some tools and this is exactly the sort of project I was hoping to find.