search

twolfson / css-validator

Validate CSS via W3C's service
The Unlicense
41 stars 8 forks source link

New: add css-validator command line client #5

Closed niedzielski closed 7 years ago

niedzielski commented 7 years ago

Add initial pass at a CLI to css-validator. This unblocks users wanting an NPM script option like html-validator offers.

twolfson commented 7 years ago

Thanks for diving into this :+1: It sounds like a great feature. I left a review with lots of feedback.

niedzielski commented 7 years ago

:+1: Thank you for the thorough feedback (and apologies for the trashy first patch!) :] I believe I've addressed all feedback.

twolfson commented 7 years ago

Thanks for iterating again on this. I feel like we're going to have a lot of nitpicks on my preferences/style so I'm going to commandeer this PR (i.e. land your code and then start commiting on top of it)

twolfson commented 7 years ago

Alright, we completed the CLI integration. It was surprisingly more work than we thought but it's done and released in 0.7.0. Thanks again for kickstarting the PR =)

niedzielski commented 7 years ago

:+1: @twolfson, thank you for completing the feature and my special gratitude for your careful review feedback which helps me grow as a developer.