search

twolfson / foundry

Release manager for npm, bower, component, PyPI, git tags, and any command you want
The Unlicense
41 stars 8 forks source link

Restore opt-in `build` on `release` for `release-npm` #2

Closed twolfson closed 9 years ago

twolfson commented 10 years ago

Originally, we had

    // If there is a build script, run it
    // TODO: This should be an opt-in action (not everyone will share this opinion)
    var result = shell.exec('node -e "f = \'./package.json\'; p = require(f); process.exit(+(!(p.scripts || {}).build))"');
    if (result.code === 0) {
      shell.exec('npm run build');
    }

in the pre-release script for npm. This was used for UMDified (vanilla, requirejs, and component compatibility from browserify-derived modules).

twolfson commented 10 years ago

This would be good as its own foundry module.

twolfson commented 10 years ago

This continues the point that setVersion should be an alias for update since this definitely comes before commit.

twolfson commented 9 years ago

I think this is now covered via custom commands (or even as its own release command) =)