twolfson / google-music.js

Browser-side JS library for controlling Google Music
The Unlicense
47 stars 6 forks source link

Move this repo into a shared space and expand into a bigger "framework" #13

Closed MarshallOfSound closed 8 years ago

MarshallOfSound commented 8 years ago

Copy paste from the message I sent a while back

Hey guys, I added both of you to this group as I think we are all "stakeholders" (if that is the correct word to use), in the potential for an expanded Google Play Music JS Framework that extends on what @twolfson has already done in his Google Music node package.

I have recently made a branch on my player that changes all my JS to use the Google Music node package, but I realized while testing that what I was doing had a few issues a) My code was still fragmented, some of it used this marvelous API. Whilst the rest was doing everything manually with obscure, unrecognizable selectors b) I had no control over this framework, if something broke I couldn't push out a fix in a few hours I would have to wait for either @twolfson to fix it or submit a PR and hope it gets merged c) These fixes still relied on the user updating their application, if for whatever reason they decided not too (some users are stubborn like that) they will not get the fixes...

I would like to propose the following We should either fork or move the Google Music node repository into a space where people who use it (Me, Radiant Player, Electron Player, Etc.) will have contributor rights to allow one of us to push fixes ASAP. This will allow changes to go out much quicker as it will take only one of us to fix everyone's applications Instead of depending upon statically released JS files we should depend on a CDN? Or the latest github release? so that updates to this framework, can be pushed independently of a version bump on our players This proposed framework should maintain the existing functionality of the current Google Music node package but should also have add on packages that allow theming support (I have some funky JS in my repo at the moment that does this) and other things like possibly a central last.fm intergration library? What do you guys think of this proposal?

Tagging relevant parties @twolfson @jacobwgillespie @chrismou

MarshallOfSound commented 8 years ago

@twolfson I didn't actually name that team, BrowserStack did. I'll submit a support ticket to get them to rename it, not sure if I can do it myself

EDIT: That was quick, team name updated

twolfson commented 8 years ago

Oh, weird o_o Thanks =)

twolfson commented 8 years ago

Woot, will check off that item on the list =)

twolfson commented 8 years ago

Alright, now that we are live on npm in 4.0.0 I can add contributors. What are your npm handles?

twolfson commented 8 years ago

Deprecation notice is posted on https://www.npmjs.com/package/google-music

MarshallOfSound commented 8 years ago

@twolfson My npm handle is marshallofsound

https://www.npmjs.com/~marshallofsound

twolfson commented 8 years ago

Alright, you are now an owner on npm:

https://www.npmjs.com/package/gmusic.js

twolfson commented 8 years ago

Going to close this PR pre-emptively since all items but #25 have been taken care of =)