search

twolfson / google-music.js

Browser-side JS library for controlling Google Music
The Unlicense
47 stars 6 forks source link

Added CONTRIBUTING.md #17

Closed twolfson closed 8 years ago

twolfson commented 8 years ago

As discussed in #13, we are adding multiple contributors so we need to document our approval process as well as general contributor guidelines. In this PR:

Notes:

I diverged from radiant-player's CONTRIBUTING.md a bit (which was linked in #13) since there are a few quirks which make our lives easier (e.g. allow branches on repo as long as people clean them up, usage of /cc convention).

/cc @MarshallOfSound @jacobwgillespie @chrismou

jacobwgillespie commented 8 years ago

LGTM :+1:

MarshallOfSound commented 8 years ago

:+1:

twolfson commented 8 years ago

Going to wait for all core contributors to approve this PR before landing it (since unanimity would be great).

jacobwgillespie commented 8 years ago

So, that leaves @chrismou, right? :wink:

chrismou commented 8 years ago

Aside from nitpicking over some wording and a weird thing I had with an anchor link, all seems good, albeit a bit wordy. LGTM :+1:

twolfson commented 8 years ago

Cool, going to fix up the wording comment and land this PR :tada:

twolfson commented 8 years ago

This has been landed/deployed in 3.3.2