search

twolfson / google-music.js

Browser-side JS library for controlling Google Music
The Unlicense
47 stars 6 forks source link

Integrated Travis CI #20

Closed twolfson closed 8 years ago

twolfson commented 8 years ago

As discussed in #19, we want to have Travis CI set up so #19 can land green. In this PR:

Notes:

Due to nightly builds as discussed in #19, we want to set up notifications/email to email all contributors to let them know about the broken build. Unfortunately, due to us pushing commits to other branches, this could get noisy quickly.

After some research, it looks like Travis CI doesn't support per-branch notifications and we have confirmed that nightlies doesn't have its own notification system:

https://github.com/coderanger/nightlies/blob/ef74410486b9060fda0737a9645ab3ec02cfe696/model.rb#L94-L107

As a result, we are adding a whitelist to only build for the master branch.

MarshallOfSound commented 8 years ago

Is there a way for others to subscribe to notifications without adding emails to that .travis.ci?

twolfson commented 8 years ago

There are non-email options but .travis.yml seems to be the only place to configure it:

https://docs.travis-ci.com/user/notifications/

twolfson commented 8 years ago

I'm also setting a flag in the Travis CI UI to restrict concurrent builds to 1 since Google Music typically dislikes multiple instances playing back music.

jacobwgillespie commented 8 years ago

Might it be possible to use something like Zapier (https://zapier.com/zapbook/email/) to send all email there and filter on the ones related to master? IMO only running tests on master defeats a large part of the usefulness of having Travis. We're going to get PRs from non-collaborators, and I think it would be super useful to have the tests run automatically rather than requiring them to manually edit the .travis.yml for testing and then back for merging.

twolfson commented 8 years ago

Whitelisting on branches doesn't prevent Travis from running for PRs. For example, this PR has Travis CI on it:

selection_201

https://travis-ci.org/twolfson/google-music.js/builds/96890868

twolfson commented 8 years ago

Sooo, are we good to land this?

MarshallOfSound commented 8 years ago

LGTM :+1:

MarshallOfSound commented 8 years ago

+1 Approve

twolfson commented 8 years ago

Going to wait for approval of @jacobwgillespie as well

twolfson commented 8 years ago

Alright, going to land this due to silence from @jacobwgillespie (with no ETA). We can always iterate on the solution later on.

jacobwgillespie commented 8 years ago

:+1: sorry for the delay