Closed twolfson closed 8 years ago
Weird - I didn't get a notification about this
I'll check it out shortly. Just en route home
Bump on this PR =/
LGTM :+1:
Going to wait until the end of the weekend for @chrismou to chime in. Otherwise, going to land it
All looks good to me :shipit:
This has been merged/released in 4.0.2
:tada:
@twolfson Out of interest, do you tend to go for a release per bug/feature/etc? Or would there be some cases where you'd store them up and release a bunch at once?
I usually do releases per bug/feature/PR. The rare case where I group PRs for a single release is for multiple breaking changes (e.g. changing many function signatures) but I prefer to avoid that.
For releases, I have been using
foundry
to manage the multiple steps. It's super helpful when we need to re-publish when there was a mistake (e.g. typo in README).In this PR:
foundry
npm run build
to foundry release steps (to guarantee most recentdist
directory)/cc @gmusic-utils/gmusic-js