search

twolfson / grunt-curl

Download files from the internet via grunt.
The Unlicense
73 stars 28 forks source link

Remove grunt.util.async and grunt.util._ #13

Closed shinnn closed 10 years ago

shinnn commented 10 years ago

grunt.util.async and grunt.util._ are deprecated. So I replaced them with async module and extend module.

twolfson commented 10 years ago

This looks good. Can we move from extend to _ to prevent any possible inconsistencies? Also, it would probably make npm dedupe work more gracefully.

shinnn commented 10 years ago

it would probably make npm dedupe work more gracefully.

I see, I'll fix this PR. Is it alright that we should use lodash module instead of extend?

twolfson commented 10 years ago

Yep, it looks like grunt@~0.4.1 uses lodash@~0.9.0.

https://github.com/gruntjs/grunt/blob/v0.4.1/package.json#L59

shinnn commented 10 years ago

fixed.

twolfson commented 10 years ago

Looks good. I will review/merge it by the end of the weekend.

twolfson commented 10 years ago

Alright, I took a little detour before merging to add Travis CI testing. This has been merged and released in 1.4.0. Thanks for the PR!

shinnn commented 10 years ago

You're welcome.