search

twolfson / grunt-zip

Zip and unzip files via a grunt plugin
MIT License
87 stars 19 forks source link

Build currently failing #38

Closed elicwhite closed 9 years ago

elicwhite commented 9 years ago

The build is currently failing on master on Travis.

twolfson commented 9 years ago

Ah, damn. Sorry for the slow reply. Thanks for the heads up. I will see what we can do.

twolfson commented 9 years ago

We have loosened up the test suite and updated our node version support (now >=0.10.0) to get it back to green. Thanks again for the heads up =)

elicwhite commented 9 years ago

Awesome. As a heads up, iojs was merged back into nodejs and the current version of node is 4.0.0. If you only specify node in your travis file you will be using that version. I'd recommend specifying that instead of iojs.

twolfson commented 9 years ago

Yep, I wanted to lock to 4.0 but it doesn't seem to be in Travis CI yet. The iojs lock is versionless convention I have been using since iojs had releases so frequently.

elicwhite commented 9 years ago

4.0.0 is definitely in Travis, but I would recommend locking to 4 instead of 4.0 since they are trying to follow semver now. iojs I believe will never have a new version on travis, and node is the new versionless one (which is probably good to have just to know how forwards compatible you are.

twolfson commented 9 years ago

Ah, fair enough with respect to semver.

With respect to using iojs, I think I was making an assumption about Travis CI. I occasionally see a blog post about them upgrading their environment support so I was thinking that one of those would exist for 4.0.0 as well:

http://docs.travis-ci.com/user/build-environment-updates/

elicwhite commented 9 years ago

Interesting. It looks like that link hasn't been updated in a while. Travis uses nvm so any version there is available on Jenkins including 4.0.0: http://docs.travis-ci.com/user/ci-environment/#Node.js-VM-images