twolfson / gulp.spritesmith

Convert a set of images into a spritesheet and CSS variables via gulp
The Unlicense
1.08k stars 81 forks source link

Getting error #94

Closed lexmills closed 8 years ago

lexmills commented 8 years ago

Error: There are some read requests waitng on finished stream at ChunckStream._end

Could someone help me with this issue?

twolfson commented 8 years ago

Could you post your gulpfile? On Jun 23, 2016 21:36, "lexmills" notifications@github.com wrote:

Error: There are some read requests waitng on finished stream at ChunckStream._end

Could someone help me with this issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/twolfson/gulp.spritesmith/issues/94, or mute the thread https://github.com/notifications/unsubscribe/AA3FWP3HAQU3tEoC5d7rrVIGknTUGvWFks5qOuA8gaJpZM4I9KbK .

lexmills commented 8 years ago

var gulp = require('gulp'), sass = require('gulp-sass'), spritesmith = require('gulp.spritesmith');

gulp.task('sass', function() { return gulp.src('sass/*.scss') .pipe(sass()) .pipe(gulp.dest('css/')) });

gulp.task('sprite', function() { var spriteData = gulp.src('images/*.png') .pipe(spritesmith({ imgName: 'sprite.png', cssName: 'sprite.css' })); spriteData.img.pipe(gulp.dest('images')); spriteData.css.pipe(gulp.dest('css')); });

gulp.task('watch', function() { gulp.watch('sass/.scss', ['sass']); gulp.watch('images/.png', ['sprite']); });

twolfson commented 8 years ago

You aren't returning nor calling back from the gulp task so gulp is assuming the task was synchronous. Please see the README for an example.

https://github.com/twolfson/gulp.spritesmith/tree/6.2.1#continuing-the-pipeline

lexmills commented 8 years ago

Is there a reason it was working before, I didn't change any of the code, and it suddenly stopped working?

I have updated my gulp file to be exactly like in the readme (with correct updates to paths), but am still getting the same error.

I tried finding someone with the same issue, but couldn't, or else I would not bother you. Just trying to understand.

twolfson commented 8 years ago

You would have a better idea of what changed on your computer than me =/ Here are some possibilities:

From my perspective, everything looks like it should work if you are using our example README. As a sanity check, I would suggest cloning this repo and running our test suite:

# Clone the repository
git clone https://github.com/twolfson/gulp.spritesmith
cd gulp.spritesmith

# Install our dependencies and dev dependencies
npm install

# Run our tests
npm test