search

twolfson / karma-electron

Karma launcher and preprocessor for Electron
The Unlicense
59 stars 21 forks source link

Add a fallback to `electron` package #10

Closed MLefebvreICO closed 8 years ago

MLefebvreICO commented 8 years ago

Also add a warning considering electron-prebuilt will be deprecated in the end of 2016.

Note: The tests were failing before I made any changes.

twolfson commented 8 years ago

Well that's confusing -- a different package for node and electron. Oh well. Can we remove the fallback logic entirely and switch over to electron (i.e. update the package.json and require('electron-prebuilt') statement)? There's no need for unnecessary fallback logic.

MLefebvreICO commented 8 years ago

@twolfson If we do that, that will cause a breaking change for all the people using it.

twolfson commented 8 years ago

Ahh, for some reason I thought this was google-music-electron. Let me re-read this PR under a new set of eyes

twolfson commented 8 years ago

The code is sound but I have some nitpicks that I will take care of on top of your commit (no sense in making you do repetition).

twolfson commented 8 years ago

This has been merged/released in 4.1.0. Thanks for the bug report and patch