twolfson / karma-electron

Karma launcher and preprocessor for Electron
The Unlicense
59 stars 21 forks source link

karma-electron crashes when using electron version 1.4.3 #16

Closed etiennejcharles closed 8 years ago

etiennejcharles commented 8 years ago

When using electron version 1.4.3 this is the error I get.

image

I reverted to version 1.4.2

And my tests now again pass.

image

Do you get the same error?

twolfson commented 8 years ago

I'm seeing failures in 1.4.3 as well yet 1.4.2 is passing. I don't see any relevant issues since 1.4.3's release. I've done a little bit of debugging and it looks like something in Karma's setup as loading http://google.com/ works fine.

twolfson commented 8 years ago

I moved to launching Karma in its continuous mode and launching electron directly. This is the error we are getting:

$ ./node_modules/.bin/electron lib/electron-launcher.js --url http://localhost:9876/
/home/todd/github/karma-electron/lib/electron-launcher.js:4
  throw err;
  ^

TypeError: Cannot set property 'openerId' of undefined
    at mergeBrowserWindowOptions (/home/todd/github/karma-electron/node_modules/electron/dist/resources/electron.asar/browser/guest-window-manager.js:44:35)
    at EventEmitter.<anonymous> (/home/todd/github/karma-electron/node_modules/electron/dist/resources/electron.asar/browser/guest-window-manager.js:144:13)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (/home/todd/github/karma-electron/node_modules/electron/dist/resources/electron.asar/browser/api/web-contents.js:219:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
twolfson commented 8 years ago

I'm going to try setting up a minimal gist to reproduce the error and opening an issue on electron.

twolfson commented 8 years ago

Alright, the issue has been reported in https://github.com/electron/electron/issues/7519. For now, I suggest sticking to Electron@1.4.2

yaooluu commented 8 years ago

@etiennejcharles I'm having the exact same issue. Thanks for reporting it and the downgrade suggestion.

@twolfson Thanks for the detailed trace of this issue! I've learned from it. :)

twolfson commented 8 years ago

Electron@1.4.4 has been released and it looks like the issue has been resolved. Closing this issue