search

twolfson / karma-electron

Karma launcher and preprocessor for Electron
The Unlicense
59 stars 21 forks source link

No custom user agent #39

Closed makarandp0 closed 5 years ago

makarandp0 commented 5 years ago

some times the code running inside electron is generic, and may need access to real userAgent. This small change adds an option to not user custom user agent.

I have tested that it works for our scenario. Please let me know what you think about adding it to main branch.

makarandp0 commented 5 years ago

@twolfson, Can you please take a look at this PR and let me know what you think about it?

twolfson commented 5 years ago

Sorry for the delay. On my way back from a very long vacation. I'll review this within the next 2 weeks

On Wed, May 1, 2019, 11:56 PM Makarand Patwardhan notifications@github.com wrote:

@twolfson https://github.com/twolfson, Can you please take a look at this PR and let me know what you think about it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twolfson/karma-electron/pull/39#issuecomment-488445003, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4KWDVL3GUZAFIE5GHK6DPTIGZ7ANCNFSM4HJRDYGQ .

twolfson commented 5 years ago

This has been released in 6.1.0. Thanks for your help!