Update README.md - Githubissues

twolfson / karma-electron

Karma launcher and preprocessor for Electron

The Unlicense

59 stars 21 forks source link

Update README.md #58

Closed mnumanuyar closed 2 years ago

mnumanuyar commented 2 years ago

Add instruction for angular cli.

mnumanuyar commented 2 years ago

I am not sure if this is fixed in some versions of angular, ~~but it is mentioned here and~~ I encountered it with

angular v13.2.4
Electron v17.1.2
Karma v2.0.0

It would be good to put it in here as this seems to be go to module for karma-electron and this detail is not well documented anywhere

twolfson commented 2 years ago

Hey @mnumanuyar, thank you for the PR! I'm unfortunately going to decline.

It seems like the ideal would be to have this be a non-issue by patching it in Angular -- it's very confusing that it would disable Karma's default behavior

If you cannot get an issue resolved with Angular, then I'd recommend adding documentation to Karma's plugin page, since I'm far from the only plugin and that seems like a better location

https://karma-runner.github.io/6.4/config/plugins.html#loading-plugins

mnumanuyar commented 2 years ago

yeah that makes sense, thanks for feed back :D