Open twolfson opened 7 years ago
We will be using the following screenshot (test/browser/actual-screenshots/find-similar-matching.png
) for our README. Please update screenshot images in this thread and update the link in the README. We don't want to bloat our repo with screenshot images (it's about 30kb crushed).
We initially had a setup for this but we didn't like the bloat:
"test-browser": "npm run build && npm run test-karma-single && npm run test-copy-docs-screenshot",
"test-copy-docs-screenshot": "if which pngcrush &> /dev/null; then src_file=\"test/browser/actual-screenshots/find-similar-matching.png\"; test -f \"$src_file\" && pngcrush \"$src_file\" docs/screenshot.png; fi",
Proof of concept test for a base64 image in GitHub issues:
Doesn't work =(
According to blog posts, we can't submit email attachments either =( It also looks like email thread ids are random UUIDs =/
Latest screenshot for README:
Latest screenshot:
We have a lot of development work left but the initial proof of concept is out in the wild. Here's what's left on our plate:
multi-image-assert
assert
tool or an--no-server
flag so we can exit earlyTODO: Simplest API will begemini-test --reporter json || multi-image-mergetool --preset gemini
(loads Gemini config, finds screens based on that, (skips initial assertion), starts server + opens browser window)gemini-test --reporter html || multi-image-mergetool --loader gemini
(e.g. a fully integrated UI likegemini-gui
), then they can write itkarma
and Sauce Labs/BrowserStack?TODO: Move from Jade to HTML so we can haveUnnecessary, we can use Jade for demo page as wellgh-pages
demo--help
)--preset gemini
flag supportrm -r gemini gemini-report; cp -r gemini-report-bak/* .
domo
tohyperscript
/hyperscript-helpers
test/test-files/gemini
as we no longer have setup for it/use itTODO: Get rid of 404 warnings in Karma tests by addingRepaired by moving to/base/
images instead of data-uriimgUrl
for all images and ditching prefix (we were going to have similar problem as we would need a/base
prefix and no encoding)commander.js
as it lacks support for variadic arguments in options, i.e.--current-images [images...]
)TODO: Make sure we test all our expected CSS (browser, index) and scripts are loaded in server page(not sure what I was thinking here...)test-files/README.md
to usemulti-image-mergetool
instead of one-off script (requires--diff-images
support on CLI)test-files/README.md
to usemulti-image-assert
(currently listens and needs Ctrl+C)--current-images
/--ref-images
not existing with no--loader
--loader
with GeminiimageSet#options.diffImage
support properly worksposition: absolute
over image[x] TODO: Add smooth scrolling to jump to similar imagesWe have decided against this as we can't predict if overlay found all the images the user desired =/ (e.g. found 2 when wanted 20)ref-images
(i.e. current image is new)isNew
propertyskip
testsquerySelector
calls frombrowser
directory, there shouldn't be any need withthis.saveEl
previousState
,newState
as parameters (should handleloading
, cachebusting images (save URLs on state), image equality, results count -- should be closer to title el)