Improve demo accuracy - Githubissues

twolfson / multi-image-mergetool

Resolve multiple image conflicts at the same time

The Unlicense

2 stars 0 forks source link

Improve demo accuracy #8

Closed twolfson closed 7 years ago

twolfson commented 7 years ago

We have created a functional demo but it's not entirely accurate:

[x] Partial updates are automatically fully approved, can we diff them somehow (e.g. pixelmatch)?
[x] Cachebusted images are not accepted version
[x] New images show broken images instead of accepted versions

twolfson commented 7 years ago

If we cannot access the internals of the existing browser-dist/index.js and we don't want to compromise it's cleanliness by adding a window.ImageSet. Maybe we could replace browser-dist/index.js with browser-dist/demo.js entirely so we have:

Sinon hooks
Load index.js
Add new stub behavior

twolfson commented 7 years ago

Completed and released in 1.32.0