search

twolfson / restructuredtext-lint

reStructuredText linter
The Unlicense
171 stars 20 forks source link

Travis: Build against more python versions #24

Closed sils closed 8 years ago

twolfson commented 8 years ago

Landing this PR now~

twolfson commented 8 years ago

This has been merged/released in 0.12.4. Thanks for the PR!

sils commented 8 years ago

thanks for merging, would you have anything against us adding windows builds for you? We're already testing your tool against windows in coala and it works, it would probably be better if you catch your windows problems before we hit them.

2015-11-16 9:05 GMT+01:00 Todd Wolfson notifications@github.com:

This has been merged/released in 0.12.4. Thanks for the PR!

— Reply to this email directly or view it on GitHub https://github.com/twolfson/restructuredtext-lint/pull/24#issuecomment-156951281 .

twolfson commented 8 years ago

I'm open to it but I typically avoid it unless the package is doing something OS specific (e.g. running a program, reading a hardcoded filepath from disk).

The reasoning is that the more versions/platforms that we test, the more likely something is to break in those external systems (e.g. what happens if Appveyor has a regression in their CI platform) which leads to more maintenance.

sils commented 8 years ago

sure then I'll not do it, as long as nothing bad happens with file paths we all should be fine.

2015-11-16 9:31 GMT+01:00 Todd Wolfson notifications@github.com:

I'm open to it but I typically avoid it unless the package is doing something OS specific (e.g. running a program, reading a hardcoded filepath from disk).

The reasoning is that the more versions/platforms that we test, the more likely something is to break in those external systems (e.g. what happens if Appveyor has a regression in their CI platform) which leads to more maintenance.

— Reply to this email directly or view it on GitHub https://github.com/twolfson/restructuredtext-lint/pull/24#issuecomment-156954853 .