search

twolfson / restructuredtext-lint

reStructuredText linter
The Unlicense
171 stars 20 forks source link

String output with --format=json due no errors #25

Closed Iyozhikov closed 8 years ago

Iyozhikov commented 8 years ago

I faced an issue when linter returned string message in case of no errors with --format=json paraeters passed. I attached patch which fix this issue.

twolfson commented 8 years ago

I don't see a patch attached to this issue =/

Iyozhikov commented 8 years ago

Hi, sorry, i thought that it was attached - https://github.com/Iyozhikov/linter-restructured/blob/master/rst-linter.patch

twolfson commented 8 years ago

Ah, thanks. I will take a look at landing that by the end of the weekend (and maybe adding a test case).

twolfson commented 8 years ago

Taking a look at landing this now

twolfson commented 8 years ago

For self-reference, I applied your patch via:

# Retrieve patch
wget https://raw.githubusercontent.com/Iyozhikov/linter-restructured/master/rst-linter.patch

# Apply and stage changes
git apply rst-linter.patch
git add -p

# Perform commit based on
# https://github.com/Iyozhikov/linter-restructured/commit/14a9a72147c9684103418ade7c1c2ab34b81340f
# https://api.github.com/repos/Iyozhikov/linter-restructured/git/commits/14a9a72147c9684103418ade7c1c2ab34b81340f
git commit -m "Resolve issue with string output during json format used" --author "Igor Yozhikov <iyozhikov@mirantis.com>" --date "2015-12-09T12:22:41Z"
twolfson commented 8 years ago

This has been landed/released in 0.14.0. Thanks for the patch =)