Closed twolfson closed 10 years ago
Sure, happy to. Please assign this to me so I don't lose track.
Added you as a collaborator and assigned to you. Please don't push any changes to master
x_x
Ahh I didn't know I had to be a collaborator to be assigned a task. I have a fork so I'll continue to send any pull requests from there.
Any progress on being able to review this?
Sorry, I've had my hands full the past couple weeks. I'll have a look at this today.
I have no other comments. :white_check_mark:
Cool, I will adjust and land this tonight =)
There are actually a lot more unquoted variables in prompt_test
than I would like. I am going to land this an follow up with a patch release for them.
Alright, this has been released in 0.19.0
. Follow-up PR for those unquoted items coming up.
As brought up in #25, a merge can sometimes be clean which makes it seem like the prompt is
git status
is normal. To remedy this behavior, various avenues were explored (e.g. new symbols, alternate colors). However, one seemed to fit in well with the current prompt:In this PR:
get_git_progress
to prompt which outputs[merge]
if a merge is occurringget_git_progress
to prompt, defaulting to redPROMPT_GIT_PROGRESS_COLOR
as an available color overrideget_git_progress
get_git_progress's
addition@rpdelaney Can you please look over the changes and approve/disapprove? Following this PR's merge, we can follow up with another one that adds all missing states (e.g.
rebase
,cherry-pick
) from thegit
code referenced in #25.