twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.
MIT License
1.14k stars 155 forks source link

Added `[merge]` keyword in prompt when a merge is in progress #28

Closed twolfson closed 10 years ago

twolfson commented 10 years ago

As brought up in #25, a merge can sometimes be clean which makes it seem like the prompt is git status is normal. To remedy this behavior, various avenues were explored (e.g. new symbols, alternate colors). However, one seemed to fit in well with the current prompt:

screenshot from 2014-02-28 02 25 00

In this PR:

@rpdelaney Can you please look over the changes and approve/disapprove? Following this PR's merge, we can follow up with another one that adds all missing states (e.g. rebase, cherry-pick) from the git code referenced in #25.

rpdelaney commented 10 years ago

Sure, happy to. Please assign this to me so I don't lose track.

twolfson commented 10 years ago

Added you as a collaborator and assigned to you. Please don't push any changes to master x_x

rpdelaney commented 10 years ago

Ahh I didn't know I had to be a collaborator to be assigned a task. I have a fork so I'll continue to send any pull requests from there.

twolfson commented 10 years ago

Any progress on being able to review this?

rpdelaney commented 10 years ago

Sorry, I've had my hands full the past couple weeks. I'll have a look at this today.

rpdelaney commented 10 years ago

I have no other comments. :white_check_mark:

twolfson commented 10 years ago

Cool, I will adjust and land this tonight =)

twolfson commented 10 years ago

There are actually a lot more unquoted variables in prompt_test than I would like. I am going to land this an follow up with a patch release for them.

twolfson commented 10 years ago

Alright, this has been released in 0.19.0. Follow-up PR for those unquoted items coming up.