Added missing quotes and made quote style consistent

twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.

MIT License

1.14k stars 155 forks source link

Added missing quotes and made quote style consistent #29

Closed twolfson closed 10 years ago

twolfson commented 10 years ago

As @rpdelaney has brought up on numerous occasions, we should be quoting our variables more often in case they contain whitespace. This PR aims to fix that.

In this PR:

Add quotes to variables and subshells missing quotes in test/prompt_test.sh, a la #28
Add quotes to variables and subshells missing quotes in .bash_prompt
Adjust string that contain quotes halfway to quote entire string in .bash_prompt

/cc @rpdelaney for review

rpdelaney commented 10 years ago

Excellent!! :-)

twolfson commented 10 years ago

Was that an approval of the PR contents or just a comment?

rpdelaney commented 10 years ago

Both? :)

twolfson commented 10 years ago

Alright, I will land this either today or tomorrow.

twolfson commented 10 years ago

This has been merged and released in 0.20.0.