search

twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.
MIT License
1.14k stars 155 forks source link

Should we display commits remaining in rebases/patches? #30

Open twolfson opened 10 years ago

twolfson commented 10 years ago

As discovered during research for the remaining in progress actions, git am and git rebase can walk through multiple commits. During each pause, there are files that list out the current step and the total amount of commits (e.g. step: 1, total: 2).

Should we display this information inside of the [rebase]/[am] notice?

todd at Euclid in ~/github/sexy-bash-prompt on dev/add.remaining.in.progress [rebase 1/20]
$

/cc @rpdelaney

twolfson commented 10 years ago

Reference from research: https://github.com/git/git/blob/v1.9-rc2/contrib/completion/git-prompt.sh#L334-L335

rpdelaney commented 10 years ago

If you're up to it, and it doesn't hit performance when we're not rebasing (i.e. don't count how many files are left to rebase if we're not rebasing), then I think it would be awesome to have that feature.

twolfson commented 10 years ago

The feature would read 2 files in their respective if statements, it won't run during any other time.

rpdelaney commented 10 years ago

Works for me.