search

twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.
MIT License
1.14k stars 155 forks source link

Massaging the build process #37

Closed rpdelaney closed 10 years ago

rpdelaney commented 10 years ago

Preparing ground for further work on build scripts.

twolfson commented 10 years ago

Could you provide more explanation to the purpose of this PR?

rpdelaney commented 10 years ago

Sure. I was starting to work on the build/test units to complement the _update_ps1 method we discussed in #36. But looking at the build scripts more closely I thought it would be wise to propose some changes that I thought were useful, but don't really belong in that branch/PR. I'll respond to your comments inline.

twolfson commented 10 years ago

Ah, thanks for the clarification

rpdelaney commented 10 years ago

All right, I rolled back a bunch of the changes originally proposed. The echo vs printf thing is a lot less interesting to me than it was originally -- I'd prefer to continue work on the other things we discussed than rework something that already works. Can you accept this as-is?

twolfson commented 10 years ago

It looks like GitHub's inline commenting is broken for a bit. Can you update

 if ! ps1_is_installed ; then

to not have a space between ps1_is_installed and the ;? It would be more consistent. Other than that, everything looks good. Also, a squash down to 2 or 3 commits would be nice but isn't necessary.

rpdelaney commented 10 years ago

Aye aye. I'll fix the formatting and try to squash/rebase the reverted commits out.

rpdelaney commented 10 years ago

Done.

twolfson commented 10 years ago

Merged and released in 0.22.0