search

twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.
MIT License
1.14k stars 155 forks source link

Revived prefixes from #40 #44

Closed twolfson closed 10 years ago

twolfson commented 10 years ago

In #40, we were making progress on prefixing everything to avoid conflicts. In this PR:

I have finished the version with prompt_ in 137a5c0 but am going to update this PR to use sexy_bash_prompt.

/cc @luizfb @rpdelaney

luizberti commented 10 years ago

@twolfson Great to see this went forward, I thought you had already merged my PR into yours and then was waiting for final version to merge into master, that's why the issue got so quiet.

One thing though, in the other issue we were discussing the idea of keeping the configuration environment variables prefixed only with PROMPT_, given that they could be purposefully be reused by other fancy prompt scripts to provide easier migration/interoperability. You seem to have renamed the env vars with the SEXY_BASH_PROMPT_ and I got curious as to why you ditched the idea. Your thoughts?

twolfson commented 10 years ago

Ah, I missed that part and seemed to have not responded. I feel that it is best to avoid conflicts by default; opt-in is much easier to handle than opt-out for an end user. However, we can still have an open discussion about it.

luizberti commented 10 years ago

In my opinion, if any conflict arrises it will most likely be intentional, and therefore not a conflict. We should probably discuss this a bit further.

cc @rpdelaney

rpdelaney commented 10 years ago

I don't see this as any kind of big deal, since it's trivial to do PROMPT_COLOR="$SEXY_BASH_PROMPT_COLOR" and so on in bashrc. Nonetheless I do agree that if conflicts arise "it will most likely be intentional, and therefore not a conflict".

twolfson commented 10 years ago

Alright, 2 vs 1 for PROMPT_ over SEXY_BASH_PROMPT_. I will update the PR shortly. I am going to keep the local lower case variables as sexy_bash_prompt_ since we are still trying to minimize unnamespaced leaks.

twolfson commented 10 years ago

Alright, I have made the updates and pushed the branch. @rpdelaney Please look through the PR.

twolfson commented 10 years ago

Also, have a happy Thanksgiving you guys =D

rpdelaney commented 10 years ago

No comments. Happy retroactive Thanksgiving :)

twolfson commented 10 years ago

Woot, merging and releasing.

twolfson commented 10 years ago

This has been merged and released in 0.24.0