Closed twolfson closed 4 years ago
Also, fwiw -- we did sanity check that this works with the PS1
extension as reported in #90 again =)
Guessing @rpdelaney is still in the process of moving. It's been 11 days since I wrote this though so I've forgotten everything. Going to give it a review and likely land it
This has been landed in 1.1.0
In #88 and #89, we moved to
PROMPT_COMMAND
and added exit code support. In #90, we discovered we broke existingPS1
extension mechanisms due to always setting the variableThis PR moves to a hybrid where we track the items we need for exit code support via a
PROMPT_COMMAND
hook and exposes them as globalsIn this PR:
PROMPT_COMMAND
as a hook, to only expose globals forPS1
PROMPT_COMMAND
extension logicPS1
to use globals fromPROMPT_COMMAND
/cc @rpdelaney