twolfson / sexy-bash-prompt

Bash prompt with colors, git statuses, and git branches.
MIT License
1.14k stars 154 forks source link

Added back exit code support #91

Closed twolfson closed 4 years ago

twolfson commented 4 years ago

In #88 and #89, we moved to PROMPT_COMMAND and added exit code support. In #90, we discovered we broke existing PS1 extension mechanisms due to always setting the variable

This PR moves to a hybrid where we track the items we need for exit code support via a PROMPT_COMMAND hook and exposes them as globals

In this PR:

/cc @rpdelaney

twolfson commented 4 years ago

Also, fwiw -- we did sanity check that this works with the PS1 extension as reported in #90 again =)

Selection_224

twolfson commented 4 years ago

Guessing @rpdelaney is still in the process of moving. It's been 11 days since I wrote this though so I've forgotten everything. Going to give it a review and likely land it

twolfson commented 4 years ago

This has been landed in 1.1.0