Speed up phantomjs engine

twolfson / spritesmith

Utility that takes sprites and converts them into a stylesheet and its coordinates

MIT License

916 stars 56 forks source link

Speed up phantomjs engine #15

Closed twolfson closed 11 years ago

twolfson commented 11 years ago

The current phantomjs test suite takes 13 seconds to run. This is caused by the bottleneck of getting stats on each image separately. Here are a few solutions

Parallelize image stats grabbing (assuming series is bottleneck)
Follow same fs/spawn as the phantomjs composition (preferred)

twolfson commented 11 years ago

It seems we already get stats in parallel

https://github.com/Ensighten/spritesmith/blob/a93b74cdfb3b539a321b131e8d7a21f6ceefc730/src/smiths/engine.smith.js#L22-L28

Now to contemplate how to mass create images/grab stats.

twolfson commented 11 years ago

Completed as of 85b09a3

The solution was to create a new method for mass image creation phantomjsEngine.createImages