search

twolfson / spritesmith

Utility that takes sprites and converts them into a stylesheet and its coordinates
MIT License
916 stars 56 forks source link

Publish to npm #6

Closed iAdramelk closed 11 years ago

iAdramelk commented 11 years ago

Hi!

First of all our library is fantastic, big thanks for it. I waited long time for something like it to appear, and I already wrote my first app with it ( https://github.com/iAdramelk/grunt-oversprite ). I make it just in a few hours, it was that easy.

But for now I have to include it with repo address. It works, but not sexy. Maybe you can publish it to npm?

twolfson commented 11 years ago

Hey! Glad to hear the repository could be of use to you.

The repository is already being hosted on npm (link) but I have made it more obvious to the README.

Additionally, I already made a grunt plugin for this as well and linked to it in the README. Sorry if that cause you any extra work. =/

iAdramelk commented 11 years ago

Cool. For some reason then I tried to find in npm, it returns error. Maybe I made mistake somewhere. Can you please add npm link to readme?

About plugin. Your plugin is cool, but it didn't work for my workflow (I'd like to have ability to develop with separate images and only combine them when I go to production). So I make plugin that lets me automatically replace old images links in css to new sprite's one with coordinates.

Will try to use npm version now.

twolfson commented 11 years ago

Ah, alright. Glad to see my repositories were modular enough for you to still use =)

iAdramelk commented 11 years ago

Tried to use npm version, have strange bug. Maybe I just do something wrong, so I'd thought about asking her first before creating new ticket.

Then I use npm install spritesmith everything works like a charm. But then I try to install it as dependency then it, for some reason, tried to also install all modules from optionalDependencies ( https://github.com/Ensighten/spritesmith/blob/master/package.json ) — both canvas and graphicsmagic.

I have graphicsmagick installed, but I didn't install cairo (because of Mac's installation problems) and so node-canvas is failng with error and take spritesmith along with it.

Do you have any ideas why is it doing it? (For a test I forked spritesmith repo and deleted optionalDependencies section, after that everything installed normally).

twolfson commented 11 years ago

Ah, that sounds like a bug indeed. Technically, optionalDependencies should not affect whether the installation passes/fails https://npmjs.org/doc/json.html#optionalDependencies

That said, you definitely should open up a bug and I will reach out to my Mac coworkers for reproducing the bug.

As relevant information, can you let us know what npm version (npm --version) and node version (node --version) you are on?