twolfson / sublime-plugin-tests

Testing framework for Sublime Text plugins
The Unlicense
22 stars 2 forks source link

sublime-installer url #27

Closed randy3k closed 10 years ago

randy3k commented 10 years ago
Moved Permanently. Redirecting to https://raw.github.com/twolfson/sublime-installer/0.1.1/install.sh

The original url doesn't work.

twolfson commented 10 years ago

That is an interesting regression. This was working at one point:

https://travis-ci.org/twolfson/sublime-plugin-tests/builds/15982135

There was an intentional choice to use rawgithub over raw.github. I don't have time to determine where the regression was introduced right now but I will take a look by the end of the weekend.

randy3k commented 10 years ago

Github must have been changing something since last commit. see travis build 301 and 302.

twolfson commented 10 years ago

Found it. It looks like rawgithub introduced a whitelist and automatically forwards non-whitelisted items with a 301. Unfortunately, .sh is not in that whitelist =(

// Introduction commit https://github.com/rgrove/rawgithub/commit/44f8175a92b54a92e37fe99f43c49175e728c2c5#diff-a4a70c1f50d4eff48812338d27b78fca

// Whitelist config https://github.com/rgrove/rawgithub/blob/7371e4d2e45819361906f4f7871eec06da41d581/conf/index.js

randy3k commented 10 years ago

another short question. i have been trying to use it on vagrant. When I run the test for ST2 I got the following.

vagrant@precise64:/vagrant$ nosetests -v
test_left_delete_multi (sublime-plugin-tests_test.TestLeftDelete) ... Xlib:  extension "RANDR" missing on display ":99.0".
Unable to connect to dbus

I have no problem with ST3 through... Do you have any thoughts?

twolfson commented 10 years ago

It is unfortunate noise we have to live with; Sublime Text is complaining it is not a full-blown X11 and just a mock.

randy3k commented 10 years ago

I am more concerned about Unable to connect to dubs. Since nosetests is just halted and does not respond.

twolfson commented 10 years ago

They are tied together. Trust me, they are normal messages. If you clone this repo and run ./test.sh inside of Vagrant, you should see the same message.

The reason it is not finishing, is your test suite might have run into a Sublime Text error. I tried to expose them as best as possible but it was not bulletproof.

If you would to continue this discussion, please open another issue.

twolfson commented 10 years ago

On another note, this PR has been merged and released in 1.0.1. Thanks for the catch!

randy3k commented 10 years ago

Thanks for this plugin. Testing in sublime is too difficult...