API support for related contribution fields

[chrisgaraffa]

I've been debugging an issue where Related and "Combined contact & related" fields for a household aren't being updated when the SumFields.Gendata api is being called.

Based on the implementation of _jsumfields_generate_data_based_on_current_data and what's written in DEVNOTES.md, it seems like this is because there's no jsumfields_update_sql defined for them.

Is this a planned feature, or something that a PR would be accepted for if we had funding for it?

[twomice]

Thanks @chrisgaraffa .

Quick answer: Yes, a PR would be much appreciated!

Longer answer:

Based on your description of the bad behavior, your description of the cause sounds correct.

In other words:

• The SumFields.Gendata api should be (conditionally, if the time is right based on various conditions) causing all Summary Fields to be updated with their correct values as of the present moment; this is typically done using the trigger_sql property.
• For fields defined by this extension that make use of jsumfields_extra to create additional triggers, the SumFields.Gendata api won't have access to the SQL of those additinal triggers, so it has no way to employ those calculations in updating the summary field value.
• Therefore, such fields should make use of jsumfields_update_sql to provide a full SQL statement that will update the summary field value correcty.

You're right, it's an oversight that some fields using jsumfields_extra don't also make use of jsumfields_update_sql, and that would explain the behavior you're reporting.