twomice / com.joineryhq.percentagepricesetfield

Other
5 stars 10 forks source link

$_GET causing problems on updated site #50

Closed philmb closed 1 year ago

philmb commented 1 year ago

I am trying to update my site to Joomla 4 and php8. This extension is giving me the error: "Unknown named parameter $_GET"

1 | () | JROOT/media/civicrm/ext/com.joineryhq.percentagepricesetfield-1.5.1/percentagepricesetfield.php:213

This error breaks not just the extension, but all of civicrm.

twomice commented 1 year ago

Looks like this was already reported with a fix by @MegaphoneJon in https://github.com/twomice/com.joineryhq.percentagepricesetfield/pull/48, which I've merged now. @philmb Could you try again with the latest master and let me know if that solves it for you?

philmb commented 1 year ago

That's it. Thank you!

twomice commented 1 year ago

Thanks @philmb and @MegaphoneJon !