search

twomice / com.joineryhq.percentagepricesetfield

Other
5 stars 11 forks source link

Display issues on contribution page with the correct total amount preceeded by $0.00 #53

Closed yashodha closed 3 months ago

yashodha commented 1 year ago

After upgrading CiviCRM to 5.46 and extension to 1.5.2

I can see display issues on contribution page/price set preview for the total display.

pri

twomice commented 1 year ago

Thanks for the report @yashodha . Since civicrm 5.46 is rather old, could I ask you to test this on 5.58.1 (latest security update) or newer, and let me know if the problem persists there?

yashodha commented 1 year ago

I have submitted a PR https://github.com/twomice/com.joineryhq.percentagepricesetfield/pull/54 Can you please take a look?

twomice commented 1 year ago

@yashodha Per my comment in the PR, I think we can do a little better here, by taking steps to preserve the original configured currency format (spaces or not). I've put such a fix in branch 53_money_format (commit 68a91b9322424750c02f657836fd7e7c3b47f5e6). This removes the entire concept of CRM.percentagepricesetfield.monetarySymbol and just uses CiviCRM's native currency formatting.

Could you try this branch https://github.com/twomice/com.joineryhq.percentagepricesetfield/tree/53_money_format and let me know your thoughts / findings?

yashodha commented 1 year ago

@twomice I have tested your patch and it works and retains the format for the amount as well. It can be merged. Thanks!