The tokens not working here

twomice / com.joineryhq.reltoken

CiviCRM extension: Provides tokens for any related contact, for all available contact tokens. E.g., to get the spouse's first name, or parent's marriage date.

Other

1 stars 5 forks source link

The tokens not working here #21

Closed jnajajreh closed 1 year ago

jnajajreh commented 2 years ago

Dears I am using civicrm from one year and I am using Related token extension, we used to use it to send thank you letter for the head of organization, so I am using the relationship type ("Head of") in my template, but unfortunately I have issue in displaying the address of the head and other information, the email token is working well, would you please help us to solve this issue? I appreciate your help Civicrm 5.46.2

1-1

twomice commented 2 years ago

Thank you for the report.

Here's what I'm seeing:

This extension will exhibit such problems (some related tokens simply won't display their values) in some newer versions of civicrm (not sure what's the latest compatible version, but perhaps as early as 5.43.x), because it relies on a deprecated utiltity function in CiviCRM core (CRM_Utils_Token::getTokenDetails())
To be compatible with newer versions of CiviCRM core, the extension should be modified to use the Token Processor approach described at https://docs.civicrm.org/dev/en/latest/framework/token/

MegaphoneJon commented 2 years ago

@jnajajreh - I think my new version of this extension (https://github.com/MegaphoneJon/com.joineryhq.reltoken/archive/refs/heads/token-processor.zip) fixes your problem. Could you please try it and let us know?

jnajajreh commented 2 years ago

Many thanks I will do

On Tue, Jun 28, 2022, 3:15 AM Jon @.***> wrote:

@jnajajreh https://github.com/jnajajreh - I think my new version of this extension ( https://github.com/MegaphoneJon/com.joineryhq.reltoken/archive/refs/heads/token-processor.zip) fixes your problem. Could you please try it and let us know?

— Reply to this email directly, view it on GitHub https://github.com/twomice/com.joineryhq.reltoken/issues/21#issuecomment-1168067503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALX54B4ZSFH22U3NN5R32ODVRI72XANCNFSM5PGPM55Q . You are receiving this because you were mentioned.Message ID: <twomice/com .@.***>

twomice commented 2 years ago

Thanks for responding @MegaphoneJon . Curious, does your linked version (this comment) contain anything other than PR #22 (now merged into this repo as of v0.4.0)? I'd be glad to get a PR on any additional improvements you might have made.

twomice commented 1 year ago

@jnajajreh and @MegaphoneJon: As of version 0.4.0, I think this repo now contains all the fixes from Jon's github fork repo (unless Jon can point out others). @jnajajreh I'm inclined to close this on the assumption that this version will address your issue. Please comment here if that's not so. Thanks!

MegaphoneJon commented 1 year ago

This looks good to close.

twomice commented 1 year ago

Thanks @MegaphoneJon .