twonds / punjab

BOSH connection manager
MIT License
183 stars 49 forks source link

Default bindAddress value of HttpbService's constructor can't work on OpenShift of Red Hat #36

Closed ijab closed 11 years ago

ijab commented 11 years ago

I noticed that HttpbService has a param -bindAddress- in its init function patched by somebody(Sorry for forgetting his/her name) to fix problem with machine having multiple NICs.

But this patch would cause punjab can't work on OpenShift for OpenShift does allow to bind to a specific IP address and range of port. I think the good default value for this param is None instead of ('0.0.0.0', 0).

And so: -- def init(self, verbose = 0, polling = 15, use_raw = False, bindAddress=("0.0.0.0", 0), session_creator = None): ++ def init(self, verbose = 0, polling = 15, use_raw = False, bindAddress=None, session_creator = None):

Works on OpenShift.

iJab