search

twoolie / NBT

Python Parser/Writer for the NBT file format, and it's container the RegionFile.
MIT License
362 stars 74 forks source link

Update Python releases support #105

Closed mfld-fr closed 5 years ago

mfld-fr commented 5 years ago

Issue #104:

mfld-fr commented 5 years ago

Looks like Travis is not supporting Python 3.7 yet...

macfreek commented 5 years ago

Good cleanup.

That zip code was there because prior to Python 2.7.9, it was simply not possible to download https://github.com/downloads/twoolie/NBT/Sample_World.tar.gz, which is done as part of the Travis test.

(Background: at the time, some mayor flaws were found in SSL, and github dropped support for SSLv3, and Python 2.7.8 was only capable of doing TLSv1.0 by first connecting with SSLv3 and then negotiating a better security level. Basically, the Python 2 ssl module was broken behind repair. In the end, this was fixed by a "unprecedented in a "bugfix" release" of Python, which was of course not a bugfix release, but a feature release, but the Python team once told no 2.8 would ever be released, so they just named it a bugfix release. Glad that got fixed. In retrospect, we did too much work to maintain backwards compatibility. So, I'm happy that all this work-around code is gone now.)

mfld-fr commented 5 years ago

What is pleasant while contributing to this project is that I learn many tips & tricks around Python :smile:. Thanks for the merge !

macfreek commented 5 years ago

A bit off-topic, but what I learned from this project is documentation, as well as unit tests. Travis is great to make sure things don't break accidentally. It still can be improved. That's what the coveralls.io button is for: it checks how much of the code was executed during a check. We need more tests :)

Looking back at the code (which I didn't touch in some years) is that some of the comments are useful, and that we need less workarounds.