Closed JanHomann closed 8 months ago
Hi @JanHomann I have fixed this issue and submitted a pull request regarding this issue, can you review if. Thanks
Hi @sampanacharya, very cool! ππ. Thank you π. I canβt approve pull requests here. But for example @twopirllc can for sure.
Actually, I just realize that the problem description I put there is nonsense. But the title says it all. It seems I accidentally copied it from another issue that I created.
Hi @JanHomann,
Should be fixed as well as faster. Available on the development branch.
Kind Regards, KJ
pandas-ta 0.3.14b0 TA-Lib 0.4.27
Problem Description
The current implementation of cdl_z() often creates low values that are higher than the open, close or high and high values that are lower than the open, close or low.
Example
Expected Behavior
'CDL_INSIDE' should return +100 and -100 like all other indicators. Alternative: Each indicator returns +1 and/or -1.