search

tworaz / sailfish-ytplayer

YouTube client for Sailfish OS
Other
32 stars 27 forks source link

Media plugin #8

Open rburchell opened 9 years ago

rburchell commented 9 years ago

Hi,

Shortly before leaving Jolla, I was working on investigating YTPlayer as a Media application plugin. I have permission to open source this work, but it is not really in a state ready for a pull request.

If you can give me a mail address or something, I'd be happy to send the code (& instructions) there.

BR, Robin

michael-k commented 9 years ago

See https://github.com/tworaz/sailfish-ytplayer/blob/master/AUTHORS

But why not push it to a branch in your github fork?

rburchell commented 9 years ago

Sure. Pushed here: https://github.com/rburchell/sailfish-ytplayer-1/tree/plugin

tworaz commented 9 years ago

Hi, the code and the idea certainly look interesting. Unfortunately I currently don't have the time to incorporate this into main branch. I've only recently found the time to finish working on long overdue 0.3.0 release. Still, thank you very much for sharing the code. I think I should have some extra free time in November so I'll cerainly have a better look at it.

ghost commented 9 years ago

Hi tworaz, has there been any further work on this?

tworaz commented 9 years ago

The honest answer is no. I looked at it a bit after 0.3.0 release, and finally decided I'm not interested in the feature at least for 2-3 next major releases. I have rather limited time to work on the project and I'd rather spend it on more user visible changes like video downloads in 0.4.0, youtube playlists support, comments, search history/suggestions, contextual searches etc.

If you're interested in working on the feature, you're more than welcome to hack on it.

Thaodan commented 9 years ago

What is needed to push this to for the current ver?

tworaz commented 9 years ago

You probably can't just push it. The original patch was based on rather old version of YTPLayer. It also moved a lot of code around which I'd rather avoid. What you basically need is to only take the new files the patch added, make sure thay're incorportated into the project, change the project template to build a library instead of an executable. Also you probably need to make sure that the library uses YTPlugin.qml file as entry point instead of YTPlayer.qml.

At least on master qml files are already packaged as resources so you can skip this part of the patch.

accumulator commented 8 years ago

Anyone looking at this? I'd love to use ytplayer-lib for using it in Quickddit.