search

twoscoops / two-scoops-of-django-1.6

Tracking thoughts and feature requests for Two Scoops of Django 1.6
51 stars 7 forks source link

Grammar issue: page 88, paragraph 2 #57

Closed shafiquejamal closed 9 years ago

shafiquejamal commented 10 years ago

I wouldn't start a sentence with "Which," so instead I suggest changing:

"...for obvious search result responses. Which can..."

to

"...for obvious search result responses. This can..."

cljohnson commented 10 years ago

Yep. Good catch. Jamal.

On the same page some minor style notes:

· On page 88, section 7.4.4, paragraph 1, second sentence: "In fact, usually they...." should be more neutral than thematic in this context and changed to "In fact, they usually...."

· On page 88, section 7.5, paragraph 1, second sentence: Changing "Unfortunately, when it came time to...." would work better than "Unfortunately, when it became time to...."

Do you want more of this as I work through the book? Or, would you prefer I shut up and a focus on learning to write good code? :) Happy to help if you like....

Charles

From: Shafique Jamal [mailto:notifications@github.com] Sent: Monday, March 24, 2014 1:14 PM To: twoscoops/two-scoops-of-django-1.6 Subject: [two-scoops-of-django-1.6] Grammar issue: page 88, paragraph 2 (#57)

I wouldn't start a sentence with "Which," so instead I suggest changing:

"...for obvious search result responses. Which can..."

to

"...for obvious search result responses. This can..."

— Reply to this email directly or view it on GitHub https://github.com/twoscoops/two-scoops-of-django-1.6/issues/57 . https://github.com/notifications/beacon/6271911__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMTMwNDA1NCwiZGF0YSI6eyJpZCI6Mjg0MDA0MjV9fQ==--5ee0585934ec1a12be0889af0a60c8a64f3ef153.gif

pydanny commented 9 years ago

:ship:

Your comments, both @shafiquejamal and @cljohnson are nice and illuminating.