search

twosigma / beakerx

Beaker Extensions for Jupyter Notebook
http://BeakerX.com
Apache License 2.0
2.8k stars 381 forks source link

set versions automatically #5728

Open scottdraves opened 7 years ago

scottdraves commented 7 years ago

npm gets the version from package.json and python gets it from _version.py

would be nice if they got it from git. i think versioneer works for python, what about npm?

MariuszJurowicz commented 7 years ago

@scottdraves could you describe a little bit how would you like it to work for npm? I think there is a lib like: npm-publish-git-tag But this approach will create some issues as: while we merge the ipywidgets v7 version we will use the fixed versions numbers instead of the * for widgets during the nbviewer publication. This version no. for widgets comes from the package.json. So that if we publish with this lib (git tag) the widget version inside beakerx extension may be different from the published version as the package.json is changed during the publication and not during the build process.