twosigma / beakerx

Beaker Extensions for Jupyter Notebook
http://BeakerX.com
Apache License 2.0
2.8k stars 382 forks source link

Upgrade to JupyterLab 1.0.5 - No Horizontal Scroll bar #8109

Open JohnOmernik opened 5 years ago

JohnOmernik commented 5 years ago

I upgraded to JupyterLab 1.0.5, and am using BeakerX 1.4.0, and when I have dataframes that have many columns, there is no Horizontal scroll bar. In previous versions of Jupyter Lab, there was always a Horizontal Scroll bar. Is there a change/setting I should be looking to?

JohnOmernik commented 5 years ago

After more research, it looks like beakerx tables are not limited by the window size, they just keep going. And Jupyter Lab doesn't see them as going further than the edge of the screen, so I don't have an horizontal scroll on JupyterLab OR BeakerX

JohnOmernik commented 5 years ago

From what I can see, BeakerX just ignores the window size, and outputs with no horizontal scroll bar. Everything is working fine with scroll bars.

JohnOmernik commented 5 years ago

Is anyone seeing this on BeakerX 1.4.0 and JupyterLab 1.0.5? Once again, to reproduce display a wide Dataframe (lots of columns) and the Horizontal Scroll bar doesn't appear. It seems if I can make Jupyter Lab Larger, I the columns are there, but no scroll bar.

If possible, I'd love to see if anyone else is (OR isn't) having this issue on the above versions, also, any tips on whether I should be posting an issue in Jupyter Lab as well, or is this likely a BeakerX thing.

I love BeakerX, but this is making my DataScience work untenable right now.

Also, I loaded the JS console, and when I try to display, I am getting this error, not sure if it's related:

index.js:9669 GET https://myserver:8000/hub/beakerx/settings 404 (Not Found)

ssadedin commented 5 years ago

Just tried the update to Beakerx 1.5.0 and the corresponding jupyter-lab and observed the same.

A second issue along with this one made me roll back to beakerx 1.0 (the second issue being that the jupyterlab_vim extension does not handle the escape key correctly any more).

piorek commented 4 years ago

@LeeTZ it's not only table display issue. As far as I can tell displaying anything wider than output area will result in truncated output.

I've tried with TableDisplay, Plot, raw pandas data.

@afshin can you look at this and see if it is not an issue that should be handled by jupyter lab team?

JohnOmernik commented 4 years ago

This is a huge blocker for us as beakerx tables are a big part of our environment, but we want to also use new features in Jupyter lab.

Thanks

ssadedin commented 4 years ago

Just noting despite all the fixes by @piorek and @LeeTZ (thanks both!) I am still observing this problem with a fresh build from master.

Would be wonderful to get it fixed!