search

twosigma / satellite

Satellite monitors, alerts on, and self-heals your Mesos cluster.
Apache License 2.0
143 stars 18 forks source link

Mf/blackhole host detector #47

Closed mforsyth closed 8 years ago

mforsyth commented 8 years ago

@dgrnbrg This is my first stab at https://github.com/twosigma/satellite/issues/40.

I've tested it using artificial event totals and it kicks in when it's supposed to.

I can definitely see the utility that integration testing would bring here... so I am excited to work on that next. It would be nice to have automated tests which ensure that satellite-slave and satellite-master behave correctly together.

mforsyth commented 8 years ago

Thanks for the review @wkf . I will adjust & resubmit this tomorrow.

mforsyth commented 8 years ago

@wkf Ready for another look.

wkf commented 8 years ago

Thanks @mforsyth, just 1 small comment this time.

mforsyth commented 8 years ago

@wkf ready once more.