search

twoslashes / twoslash

Markup for generating rich type information in your documentations ahead of time.
https://twoslash.netlify.app/
MIT License
506 stars 17 forks source link

Changed moduleResolution to NodeNext #42

Closed mattpocock closed 3 months ago

mattpocock commented 4 months ago

twoslash-cdn (and possibly other packages in the repo) can't currently be run in a Node.js environment.

This is mainly due to a single import.

So, I updated the root tsconfig.json to use NodeNext, and updated all import paths to follow it.

This will solve my downstream issue.

LMK if you want me to raise an issue to link to, but I figured this was a quick win.

netlify[bot] commented 4 months ago

Deploy Preview for twoslash ready!

Name Link
Latest commit 41c64e3b6559566bbc884a56708e2b8a835a747e
Latest deploy log https://app.netlify.com/sites/twoslash/deploys/6662dfa85036e300087f925d
Deploy Preview https://deploy-preview-42--twoslash.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

antfu commented 3 months ago

Switched to Bundler in https://github.com/twoslashes/twoslash/commit/57ed17a4df208cfd83078fa1ab5809b2f59e9a5f as it's also more closed to the fact that we are bundling the source code. unbuild already generated explicit extension in .mjs file so it the runtime should be strict already.

Thanks for bringing this up.