search

twostraws / CodeScanner

A SwiftUI view that is able to scan barcodes, QR codes, and more, and send back what was found.
MIT License
986 stars 272 forks source link

fix: #85 unreliable torch #111

Closed nitricware closed 1 year ago

nitricware commented 1 year ago

Fixes an issue where the CaptureSession became unresponsive while the torch was on or where the CaptureSession wouldn't properly start at all when the torch was on by default. Fixes #85

nitricware commented 1 year ago

You're right. Curious why it worked on my device. With this fix it should now work.

I'm new to contributing to packages and my workflow may be sub-optimal at best (I'm sure it is) I copied the code into my project and tweaked it until it worked. then i copied the two files back to the repository, commited and pushed and filed a pull a request. do you have any resources on how to make this better/easier?

demolisher2000 commented 1 year ago

@NathanFallet Is it possible to merge this fix and produce a new version? We would like to use this library, but this bug is blocking us from it

nathanfallet commented 1 year ago

@NathanFallet Is it possible to merge this fix and produce a new version? We would like to use this library, but this bug is blocking us from it

Sorry I didn't see the notification he fixed the thing, and forgot to check. I'm merging that!