twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.8k stars 306 forks source link

Don't split on space #1

Closed davedelong closed 4 years ago

davedelong commented 4 years ago

Process wants an array of strings to pass as parameters. While it definitely looks simpler to just pass in a single string and split it based on space, this can cause odd problems in weird cases (for example: spaces in paths).

This commit changes the simctl method to accept a variadic array of parameters, so that it doesn't have to do error-prone string splitting

twostraws commented 4 years ago

Love it – thank you!